fixes #428: Adding hover effect on the buttons #435
Conversation
| @@ -33,8 +33,8 @@ | |||
| "next-plausible": "^3.11.1", | |||
| "next-sitemap": "^4.2.3", | |||
| "node-ical": "0.16.1", | |||
| "react": "18.2.0", | |||
| "react-dom": "18.2.0", | |||
| "react": "^18.2.0", | |||
There was a problem hiding this comment.
@VivekJaiswal18 Why this change?
There was a problem hiding this comment.
@benjagm I introduced this change so that if minor patches were introduced by the library then anyone installing it can benefit from it (if anyone does npm install react/react-dom).
But if you think it should not be done then I can remove it.
There was a problem hiding this comment.
I think its good to remove that change since it also modifies files like package-lock.json and yarn.lock and ultimately increases the PR size.
|
I checked the changes in responsive mode using Firefox and chrome dev tools. I found that its working fine if touch simulation mode is turned off. |
…he landing page
|
@VivekJaiswal18 Can you please take a look to the feedback provided in the review? Before merge you'll need to fix the merge conflicts as well. |
|
@VivekJaiswal18 if you need any help feel free to ask : ) |
Okay @benjagm looking into it..sorry for the delay! |
removed "block" from the classname Co-authored-by: Dhairya Majmudar <[email protected]>
Co-authored-by: Dhairya Majmudar <[email protected]>
|
PR for this issue is provided in #497 considering the Feedback provided in the review |
What kind of change does this PR introduce?
feature fix
Issue Number:
Summary
Added hover effect to the buttons
Issue link: #428
Does this PR introduce a breaking change?
No