-
-
Notifications
You must be signed in to change notification settings - Fork 276
Migrate Button, Radio, and DropdownMenu to ShadCN and Add Tests +2 issues resolved #1709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
idanidan29
wants to merge
30
commits into
json-schema-org:main
Choose a base branch
from
idanidan29:phase-1.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 23 +5
Lines 448 475 +27
Branches 116 122 +6
=========================================
+ Hits 448 475 +27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Button
,Radio
andCollapsible
elements.Issue Number:
Screenshots/videos:
Screen.Recording.2025-06-14.234317.mp4
Summary
This PR:
Button.tsx
,Radio.tsx
, andDropdownMenu
components to the ShadCN library.button
component to improve dark mode compatibility (open to feedback).Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.