-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby JSON schema validator in JSON schema Ecosystem #1506
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1506 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetrahi why these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DhairyaMajmudar, I only made changes to the tooling-data.yml file. The slug-page.tsx file was included in my pull request because I created the PR from the main branch. However, I’ve ensured that these changes won’t affect any existing code. Additionally, since my previous PR hasn’t been merged yet, its commits are also reflected in the main branch.
Hi @jagpreetrahi! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @jagpreetrahi! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: breaking changes information Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the issue and approved the PR. Thanks for your contributions.
What kind of change does this PR introduce?
Add Ruby JSON schema validator in JSON Ecosystem
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
No
Summary
Does this PR introduce a breaking change?
No