Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby JSON schema validator in JSON schema Ecosystem #1506

Merged
merged 6 commits into from
Mar 16, 2025

Conversation

jagpreetrahi
Copy link
Contributor

@jagpreetrahi jagpreetrahi commented Mar 11, 2025

What kind of change does this PR introduce?
Add Ruby JSON schema validator in JSON Ecosystem

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?
No

Summary

Does this PR introduce a breaking change?
No

@jagpreetrahi jagpreetrahi requested a review from a team as a code owner March 11, 2025 12:59
Copy link

github-actions bot commented Mar 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 093fd08

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (219521e) to head (093fd08).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1506   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jagpreetrahi why these changes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DhairyaMajmudar, I only made changes to the tooling-data.yml file. The slug-page.tsx file was included in my pull request because I created the PR from the main branch. However, I’ve ensured that these changes won’t affect any existing code. Additionally, since my previous PR hasn’t been merged yet, its commits are also reflected in the main branch.

Copy link

Hi @jagpreetrahi! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: breaking changes information

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Hi @jagpreetrahi! Thanks a lot for your contribution!

I noticed that the following required information is missing or incomplete: breaking changes information

Please update the PR description to include this information. You can find placeholders in the PR template for these items.

Thanks a lot!

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the issue and approved the PR. Thanks for your contributions.

@benjagm benjagm merged commit b94850c into json-schema-org:main Mar 16, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add or Modify json-schema gem in JSON Schema Ecosystem
3 participants