Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cypress-ajv-schema-validator from Javascript to JavaScript #1357

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

Kiina
Copy link
Contributor

@Kiina Kiina commented Jan 22, 2025

Currently on the page the cypress-ajv-schema-validator is the only one that writes it Javascript instead of JavaScript. Which means it ends up with it's own entry on:

https://json-schema.org/tools?query=&sortBy=name&sortOrder=ascending&groupBy=languages&licenses=&languages=&drafts=&toolingTypes=&environments=&showObsolete=false#javascript while also breaking the anchor link (since that one is 100% case insensitive).

@Kiina Kiina requested a review from a team as a code owner January 22, 2025 11:03
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Jan 22, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview bc0709a

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (bc0709a).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1357   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

LGTM 👍🏻

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 5abdd7b into json-schema-org:main Feb 1, 2025
13 checks passed
Copy link

github-actions bot commented Feb 1, 2025

Congratulations, @Kiina for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR that already has two approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants