Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - fix markdown render in tools page #1351

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

Karan-Palan
Copy link
Contributor

What kind of change does this PR introduce?

Bugfix: Ensures that tooling listing notes are processed as markdown.

Issue Number:

Screenshots/videos:

Screencast.from.2025-01-21.15-36-50.webm

If relevant, did you update the documentation?

No

Summary

This PR addresses the issue where tooling listing notes were not being processed as markdown. The raw markdown text was displayed instead of rendering correctly. The issue occurred due to a missing markdown parser in the rendering pipeline for these notes. The changes fix that

Does this PR introduce a breaking change?

No

@Karan-Palan Karan-Palan requested a review from a team as a code owner January 21, 2025 17:29
Copy link

github-actions bot commented Jan 21, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview f0f21f4

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ee9538b) to head (f0f21f4).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1351   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its getting difficult to differentiate between plain text and URL link, pls. fix them

@Karan-Palan
Copy link
Contributor Author

Its getting difficult to differentiate between plain text and URL link, pls. fix them

I used the StyledMarkdown component and now it looks correct

image

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@DhairyaMajmudar DhairyaMajmudar added the ready-to-merge PR that already has two approvals. label Jan 31, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit 32a4525 into json-schema-org:main Feb 1, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge PR that already has two approvals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Tooling listing notes is not processed as markdown
3 participants