fix[dark-mode-toggle]: fix dark/light mode toggle on mobile#1332
Merged
benjagm merged 2 commits intojson-schema-org:mainfrom Mar 4, 2025
Merged
fix[dark-mode-toggle]: fix dark/light mode toggle on mobile#1332benjagm merged 2 commits intojson-schema-org:mainfrom
benjagm merged 2 commits intojson-schema-org:mainfrom
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 382 +9
Branches 94 97 +3
=========================================
+ Hits 373 382 +9 ☔ View full report in Codecov by Sentry. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
|
I am not able to reproduce the issue in production. Can you please check again if the issue is still relevant? |
Contributor
Author
I checked it on my phone, still facing this issue screen-20250201-212620.mp4And this is after the change (tested on this PRs deployment) screen-20250201-212952.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bugfix: Ensures the dark/light mode toggle closes automatically when the user clicks outside the toggle or interacts with other elements on the mobile view.
Issue Number:
Screenshots/videos:
Screencast.from.2025-01-19.19-10-35.webm
If relevant, did you update the documentation?
No
Summary
#1281 - This PR resolves the issue where the dark/light mode toggle on the JSON Schema website did not close automatically when the user clicked outside it or interacted with other page elements in the mobile view.
Does this PR introduce a breaking change?