feat: Added Esc functionality and improve styling of cancel button in ToolingDetail modal #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
DhairyaMajmudar
requested changes
Jan 21, 2025
There was a problem hiding this comment.
@thepiyush-303 good work with this PR, just a comment then we're good to go
There was a problem hiding this comment.
Changes in this is not required pls. remove them
DarhkVoyd
reviewed
Jan 21, 2025
There was a problem hiding this comment.
The functionality code looks good to me. @DhairyaMajmudar I rely on your decision on the styling/css changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Screencast.from.2025-01-19.02-05-36.webm
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?