Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : pro help sidebar alignment and add buttons #1310

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −10
Open

Fix : pro help sidebar alignment and add buttons #1310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fed9cd
fix[docs]: update arrow links across pages and sidebar
Karan-Palan Jan 14, 2025
931827a
fix[docs]: align sidebar and add navigation buttons to pro-help page
Karan-Palan Jan 14, 2025
255fabc
fix[docs]: fix prettier issue
Karan-Palan Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion components/Sidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,11 @@ export const DocsNav = ({
setOpen={setOpen}
/>
<DocLink uri='/overview/faq' label='FAQ' setOpen={setOpen} />
<DocLink uri='/pro-help' label='Pro Help' setOpen={setOpen} />
<DocLink
uri='/overview/pro-help'
label='Pro Help'
setOpen={setOpen}
/>
<DocLink
uri='/overview/similar-technologies'
label='Similar Technologies'
Expand Down
4 changes: 2 additions & 2 deletions pages/overview/faq/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ export default function Content() {
<NextPrevButton
prevLabel='Case Studies'
prevURL='/overview/case-studies'
nextLabel='Similar Technologies'
nextURL='/overview/similar-technologies'
nextLabel='Pro Help'
nextURL='/overview/pro-help'
/>
<DocsHelp markdownFile={markdownFile} />
</SectionContext.Provider>
Expand Down
16 changes: 11 additions & 5 deletions pages/pro-help/index.page.tsx → pages/overview/pro-help/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import React from 'react';
import fs from 'fs';
import { getLayout } from '~/components/SiteLayout';
import { getLayout } from '~/components/Sidebar';
import Head from 'next/head';
import { Headline1 } from '~/components/Headlines';
import { SectionContext } from '~/context';
import { DocsHelp } from '~/components/DocsHelp';
import NextPrevButton from '~/components/NavigationButtons';

interface ContractorLink {
title: string;
Expand Down Expand Up @@ -48,16 +49,15 @@ export default function ProHelp({ contractorData }: ProHelpPageProps) {
const newTitle = 'Need pro help with JSON Schema?';

return (
<SectionContext.Provider value='pro-help'>
<SectionContext.Provider value='docs'>
<Head>
<title>{newTitle}</title>
</Head>
<div
className='max-w-screen-xl block px-4 sm:px-6 lg:px-8 mt-12 mx-auto w-full'
className='max-w-screen-xl block lg:px-8 mx-auto w-full pt-0 mt-0'
data-testid='pro-help'
>
<br />
<div className='mt-6'>
<div>
<Headline1>{newTitle}</Headline1>
<p>
Whether you need training, personalized advice, or custom JSON
Expand Down Expand Up @@ -208,6 +208,12 @@ export default function ProHelp({ contractorData }: ProHelpPageProps) {
<br />
</div>
</div>
<NextPrevButton
prevLabel='FAQ'
prevURL='/overview/faq'
nextLabel='Similar Technologies'
nextURL='/overview/similar-technologies'
/>
<DocsHelp />
</div>
</SectionContext.Provider>
Expand Down
4 changes: 2 additions & 2 deletions pages/overview/similar-technologies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
section: docs
title: Similar Technologies
prev:
label: FAQs
url: '/overview/faq'
label: Pro Help
url: '/overview/pro-help'
next:
label: Code of Conduct
url: '/overview/code-of-conduct'
Expand Down
Loading