Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog page Tab Improvement. #1288

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Blog page Tab Improvement. #1288

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8f762a
blog page fix
cbum-dev Jan 10, 2025
0b4839b
Update index.page.tsx
cbum-dev Jan 12, 2025
191c3d4
Update index.page.tsx
cbum-dev Jan 12, 2025
4b5e5e4
Update index.page.tsx
cbum-dev Jan 12, 2025
375a5de
Update index.page.tsx
cbum-dev Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 17 additions & 30 deletions pages/blog/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ const PATH = 'pages/blog/posts';
import TextTruncate from 'react-text-truncate';
import generateRssFeed from './generateRssFeed';
import { useRouter } from 'next/router';
import useSetUrlParam from '~/lib/useSetUrlParam';
import { SectionContext } from '~/context';

type Author = {
Expand Down Expand Up @@ -75,7 +74,6 @@ export default function StaticMarkdownPage({
filterTag: any;
}) {
const router = useRouter();
const setParam = useSetUrlParam();
const [currentFilterTag, setCurrentFilterTag] = useState<blogCategories>(
filterTag || 'All',
);
Expand All @@ -92,36 +90,17 @@ export default function StaticMarkdownPage({
setCurrentFilterTag(filterTag);
}, [filterTag]);

const handleClick = (event: { currentTarget: { value: any } }) => {
const clickedTag = event.currentTarget.value;
setParam('type', clickedTag);

const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => {
event.preventDefault(); // Prevent default scrolling behavior
const clickedTag = event.currentTarget.value as blogCategories;
if (clickedTag === 'All') {
setParam('type', null);
} else {
setCurrentFilterTag('All');
history.replaceState(null, '', '/blog'); // Update the URL without causing a scroll
} else if (isValidCategory(clickedTag)) {
setCurrentFilterTag(clickedTag);
}

// Check if the user is already on the "/blog" page
if (router.pathname === '/blog') {
if (router.query.type) {
// Remove the 'type' query parameter from the URL
setParam(
'type',
router.query.type === clickedTag ? undefined : clickedTag,
);
}
setCurrentFilterTag(clickedTag);
} else {
// If not on the "/blog" page, navigate to the "/blog" page with the type tag as a query parameter
router.replace(
{ pathname: '/blog', query: { type: clickedTag } },
undefined,
{ shallow: true },
);
history.replaceState(null, '', `/blog?type=${clickedTag}`); // Update URL
}
};

const recentBlog = blogPosts.sort((a, b) => {
const dateA = new Date(a.frontmatter.date).getTime();
const dateB = new Date(b.frontmatter.date).getTime();
Expand Down Expand Up @@ -274,10 +253,18 @@ export default function StaticMarkdownPage({
onClick={(e) => {
e.preventDefault();
e.stopPropagation();
setParam('type', frontmatter.type);

if (frontmatter.type) {
setCurrentFilterTag(frontmatter.type);
history.replaceState(
null,
'',
`/blog?type=${frontmatter.type}`,
);
}
}}
>
{frontmatter.type}
{frontmatter.type || 'Unknown Type'}
</div>
</div>
<div className='text-lg font-semibold'>
Expand Down
Loading