🐛 Bug #1248 fixed , [bold text harder to read] #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1271 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
|
Congratulations, @adityajha2005 for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
🐛 Bugfix : Improves the contrast of bold text in dark mode.
Issue Number:
Closes #1248
Screenshots/videos:
Before : [
]
After :
If relevant, did you update the documentation?
No updates were needed as this is a UI bugfix.
Summary
This PR fixes a bug where bold text in dark mode had insufficient contrast, making it harder to read compared to light mode. The fix enhances the visibility of bold text while maintaining a cohesive design. This resolves a common complaint about text readability in dark mode.
Does this PR introduce a breaking change?
No.
Additional Notes:
Tested on different devices and browsers to ensure consistency.
I didn't implement anything drastically new as all of it was aligned with the theme of the website.