Fix: Consistent Card Heights on Ambassadors Page and Update Twitter Logo to X #1256
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
In the file Ambassadors.json, some links are broken for ex. as the base Urls are already attached in the AmbassadorCard.tsx file. If required, should I fix those as a part of this PR too?
"github": "https://github.com/Estherokafor05/My-portfolio",
"twitter": "https://x.com/Estherokafor_",
"linkedin": "https://www.linkedin.com/in/okaforesther/",
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1256 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
|
I'm sad to see the bird go. |
I think that is not necessary for now. Thanks! |
|
Congratulations, @Karan-Palan for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
Bugfix: Ensures consistent card heights on the Ambassadors page for a visually uniform layout and update Twitter logo to X.
Issue Number:
Screenshots/videos:
Before:
After:
Screencast.from.2025-01-07.01-36-43.webm
If relevant, did you update the documentation?
No.
Summary
This PR addresses the inconsistent card heights on the Ambassadors page, which were previously determined by the text content length. The update ensures uniform card heights by applying consistent CSS styling, improving the visual aesthetics and user experience of the page, also updating the twitter logo to X.
Does this PR introduce a breaking change?
No.