Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hover effects to filter section for improved UX #1247

Closed
wants to merge 1 commit into from

Conversation

Shayan12456
Copy link

@Shayan12456 Shayan12456 commented Jan 5, 2025

What kind of change does this PR introduce?
Feature: Adds hover effects to the filter section.

Issue Number:

Screenshots/videos:
Page Link:

Before:

Screen.Recording.2025-01-05.at.11.22.52.PM.mov

After:

Screen.Recording.2025-01-05.at.11.23.49.PM.mov

If relevant, did you update the documentation?
No

Summary
This PR adds hover effects to the filter section, enhancing the user experience by providing visual feedback when interacting with filters. Resolves the lack of interactivity reported in issue #1216.

Does this PR introduce a breaking change?
No, the changes are backward-compatible.

@Shayan12456 Shayan12456 requested a review from a team as a code owner January 5, 2025 18:24
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Jan 5, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview fd367df

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5114356) to head (fd367df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjagm
Copy link
Collaborator

benjagm commented Jan 7, 2025

Hi @Shayan12456 . I am going to close this PR as the linked issues are still in the triage process. Please follow the contributing guidelines before submitting a PR. Before sending a PR you need to be assigned to the issue.

@benjagm benjagm closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Adding hovering effects to a filter section will improve the user experince
2 participants