Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of navigation buttons on each page of website #1208

Conversation

Utkarsh-123github
Copy link
Contributor

@Utkarsh-123github Utkarsh-123github commented Dec 23, 2024

What kind of change does this PR introduce?

  • Enhancement : Added navigation buttons to each page of the website for better navigation throughout the website

Issue Number:

Screenshots/videos:

  • A sample screenshot showing the navigation buttons
    Screenshot 2024-12-23 231650

Summary
This PR basically adds navigation buttons to each page of the website for better user experience and ease of navigation throughout the website.

Does this PR introduce a breaking change?
No

@Utkarsh-123github Utkarsh-123github requested a review from a team as a code owner December 23, 2024 17:49
Copy link

github-actions bot commented Dec 23, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 6b44c5f

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (8676fc2) to head (6b44c5f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@techmannih
Copy link
Contributor

@Utkarsh-123github #1084

@Utkarsh-123github
Copy link
Contributor Author

Thanks @techmannih for mentioning, but that PR which you tagged just provides navigation buttons for the overview and getting started section of the website, but my PR provides navigation for complete website i.e Overview, Getting started, Reference and Specification sections. I think this PR will be more suitable for this enhancement as it provides complete feature

@benjagm
Copy link
Collaborator

benjagm commented Dec 27, 2024

@Utkarsh-123github Please, dont submit a PR to an issue if you have not been assigned to it.

@Utkarsh-123github
Copy link
Contributor Author

Utkarsh-123github commented Dec 27, 2024

Got it @benjagm .
Actually I submitted this PR in addition to the feature which you instructed in the review video of the PR #1084 that we need navigation buttons for every section and you mentioned in the video that other contributors can contribute to other sections. So this PR was related with that.

Anyways, I'll keep in mind and will make sure that same thing doesn't get repeated.

Also please tell should I close this PR ?

Thank you.

@benjagm
Copy link
Collaborator

benjagm commented Dec 27, 2024

Hi @Utkarsh-123github . Thanks a lot for your contribution! Next time let's sync before sending the PR. Otherwise we can have different people working on the same issue and that is not idea.

We already merged #1084 for the Overview Section. Do you mind reviewing this solution and apply the same approach in your PR? What sections are you implementing here?

@Utkarsh-123github
Copy link
Contributor Author

Yes sure @benjagm , I'll update my PR by tonight.
I am working on navigation of Getting started , Reference and Specifications section.

@Utkarsh-123github
Copy link
Contributor Author

I am closing this PR, will push the changes with a new PR and will update soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants