-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of navigation buttons on each page of website #1208
Addition of navigation buttons on each page of website #1208
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1208 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
Thanks @techmannih for mentioning, but that PR which you tagged just provides navigation buttons for the overview and getting started section of the website, but my PR provides navigation for complete website i.e Overview, Getting started, Reference and Specification sections. I think this PR will be more suitable for this enhancement as it provides complete feature |
@Utkarsh-123github Please, dont submit a PR to an issue if you have not been assigned to it. |
Got it @benjagm . Anyways, I'll keep in mind and will make sure that same thing doesn't get repeated. Also please tell should I close this PR ? Thank you. |
Hi @Utkarsh-123github . Thanks a lot for your contribution! Next time let's sync before sending the PR. Otherwise we can have different people working on the same issue and that is not idea. We already merged #1084 for the Overview Section. Do you mind reviewing this solution and apply the same approach in your PR? What sections are you implementing here? |
Yes sure @benjagm , I'll update my PR by tonight. |
I am closing this PR, will push the changes with a new PR and will update soon. |
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
Summary
This PR basically adds navigation buttons to each page of the website for better user experience and ease of navigation throughout the website.
Does this PR introduce a breaking change?
No