Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a one line disclaimer that environment variables are optional to run the code on local machine. #1090

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

AnithaKraman
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

  • Closes #___
  • Related to #___
  • Others - Added a one line disclaimer that environment variables are optional to run the code on local machine.

Screenshots/videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@AnithaKraman AnithaKraman requested a review from a team as a code owner November 5, 2024 00:16
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Nov 5, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 7dfe67b

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (26a1127) to head (7dfe67b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1090   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@benjagm benjagm merged commit 1c0fc29 into json-schema-org:main Nov 8, 2024
11 checks passed
Copy link

github-actions bot commented Nov 8, 2024

Congratulations, @AnithaKraman for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants