Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add some keywords in documentation #1079

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

techmannih
Copy link
Contributor

What kind of change does this PR introduce?
add Minimum, maxItem, maxlength, minContain, format(Assertion) and format (Annotation) keywords in the documentation.

Issue Number:
Issue #1068

@techmannih techmannih requested a review from a team as a code owner October 28, 2024 09:42
Copy link

github-actions bot commented Oct 28, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 46509a9

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (26a1127) to head (46509a9).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1079   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24 label Oct 28, 2024
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for filling in the missing pieces. I found a couple links that aren't quite right.

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar @jdesrosiers please check now

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Jason for helping in review : )

@techmannih I've left few suggestion to resolve, pls. have a look.

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar Please check this PR

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you so much for the PR 🚀

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@benjagm benjagm merged commit 718dab5 into json-schema-org:main Nov 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest-accepted Pull requests accepted for Hacktoberfest'24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants