-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update references from Twitter to X in documentation and links. #1071
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
@SarthakPaandey can you pls. fix the failing workflow |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1071 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
@DhairyaMajmudar I have fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @SarthakPaandey, Look good to me 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congratulations, @SarthakPaandey for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
Screenshots/videos:
N/A - URL updates only
If relevant, did you update the documentation?
Yes - All documentation files including README.md and CONTRIBUTING.md have been updated to reflect the new X.com nomenclature.
Summary
This PR implements comprehensive updates across our codebase to reflect Twitter's rebranding to X. Changes include:
Core Changes:
Files Modified:
Does this PR introduce a breaking change?
No - All changes are backward compatible. Old Twitter links will automatically redirect to X.com.
Additional Context
Please review the changes and let me know if any adjustments are needed.
Thanks!