Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing and style guides for documentation #1013

Merged

Conversation

valeriahhdez
Copy link
Contributor

What kind of change does this PR introduce?
This PR contains the style guide and contributing guide for documentation. The goal of this documents is to help people interested in contributing to documentation learn about our processes and text-formatting conventions for creating consistent documentation.

Issue Number:

Screenshots/videos:

If relevant, did you update the documentation?

Summary

We need a more comprehensive guide for contributing to documentation and a style guide for creating consistent documentation. This PR adds two new documents to help newcomers start contributing to docs.

Does this PR introduce a breaking change?. No

@valeriahhdez valeriahhdez added 📝 Documentation Indicates improvements or additions to documentation. GSoD Google Season of Docs labels Oct 9, 2024
@valeriahhdez valeriahhdez self-assigned this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (34e59ce) to head (4c7d36f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1013   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valeriahhdez valeriahhdez requested a review from benjagm October 9, 2024 20:02
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments and suggestions. Overall looks great! Good job Valeria.

Let's change the PR from draft to ready to review please.

@valeriahhdez valeriahhdez marked this pull request as ready for review October 12, 2024 10:12
@valeriahhdez valeriahhdez requested a review from a team as a code owner October 12, 2024 10:12
@valeriahhdez
Copy link
Contributor Author

Added a few comments and suggestions. Overall looks great! Good job Valeria.

Let's change the PR from draft to ready to review please.

Thank you @benjagm! I attended your comments and changed the status of the PR

Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @valeriahhdez . Let's merge it!

Integrate Benjamin's comments into style-guide.md
Include Benjamin's comments in CONTRIBUTING-docs.md
@valeriahhdez valeriahhdez force-pushed the contributing-style-guides branch from 09addcd to 4c7d36f Compare October 23, 2024 13:18
@valeriahhdez valeriahhdez merged commit 79be246 into json-schema-org:main Oct 23, 2024
8 of 9 checks passed
Copy link

Congratulations, @valeriahhdez for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Indicates improvements or additions to documentation. GSoD Google Season of Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📝 Docs]: Add CONTRIBUTING-docs.md and style-guide.md
2 participants