-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributing and style guides for documentation #1013
Add contributing and style guides for documentation #1013
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1013 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 373 373
Branches 94 94
=========================================
Hits 373 373 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments and suggestions. Overall looks great! Good job Valeria.
Let's change the PR from draft to ready to review please.
Thank you @benjagm! I attended your comments and changed the status of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @valeriahhdez . Let's merge it!
Integrate Benjamin's comments into style-guide.md
Include Benjamin's comments in CONTRIBUTING-docs.md
09addcd
to
4c7d36f
Compare
Congratulations, @valeriahhdez for your first pull request merge in this repository! 🎉🎉. Thanks for your contribution to JSON Schema! |
What kind of change does this PR introduce?
This PR contains the style guide and contributing guide for documentation. The goal of this documents is to help people interested in contributing to documentation learn about our processes and text-formatting conventions for creating consistent documentation.
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
We need a more comprehensive guide for contributing to documentation and a style guide for creating consistent documentation. This PR adds two new documents to help newcomers start contributing to docs.
Does this PR introduce a breaking change?. No