Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog page Tab Improvement. #1288

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

cbum-dev
Copy link

What kind of change does this PR introduce?

Improved the blog category navigation section.
Previously it was scrolling up upon changing the tab but now its not doing so.

Issue Number:

Screenshots/videos:

Screencast.From.2025-01-10.22-33-50.mp4

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

@cbum-dev cbum-dev requested a review from a team as a code owner January 10, 2025 17:05
Copy link

github-actions bot commented Jan 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 375a5de

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4fe7488) to head (375a5de).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1288   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I click on category button which are within blog cards, I'm still scrolling back to up. Pls. fix that too.

@cbum-dev
Copy link
Author

When I click on category button which are within blog cards, I'm still scrolling back to up. Pls. fix that too.

Done.

Copy link
Member

@DhairyaMajmudar DhairyaMajmudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Clicking on blog category tab scrolling to top.
2 participants