Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Update Twitter Logo to X on Ambassadors page #1254

Closed
Karan-Palan opened this issue Jan 6, 2025 · 0 comments · Fixed by #1256
Closed

🐛 Bug: Update Twitter Logo to X on Ambassadors page #1254

Karan-Palan opened this issue Jan 6, 2025 · 0 comments · Fixed by #1256
Assignees
@Karan-Palan
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Karan-Palan
Copy link
Contributor

Describe the bug

On the JSON Schema Ambassadors page, the the logo of Twitter should be changed to X since the company rebranded itself. This would help maintain consistency across the website (as the footer and other parts have X logo)

Steps To Reproduce

  1. Navigate to https://json-schema.org/ambassadors.
  2. Observe the cards for each ambassador.
  3. Note that X logo and links haven't been updated

Expected Behavior

The logo and the links should be updated to X

Screenshots

image

Device Information [optional]

No response

Are you working on this issue?

Yes

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@Karan-Palan Karan-Palan added Status: Triage This is the initial status for an issue that requires triage. 🐛 Bug Indicates that the issue is a bug or defect. labels Jan 6, 2025
@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 6, 2025
@Karan-Palan Karan-Palan mentioned this issue Jan 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karan-Palan Karan-Palan

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Consistent Card Heights on Ambassadors Page and Update Twitter Logo to X Karan-Palan/website
2 participants
@DhairyaMajmudar @Karan-Palan