Skip to content

Commit

Permalink
[web-release-tooling]: Minor fixes web tooling page (#913)
Browse files Browse the repository at this point in the history
* add /implementations to /tools redirects

* fix /tools sidebar dropdown scrollbar

* fix nav link does not reset filters

* fix redirect typo

* update yarn lock

* fix redirects

* move wild card redirect to last

* fix dependencies problem

---------

Co-authored-by: Benjamin Granados <[email protected]>
  • Loading branch information
DarhkVoyd and benjagm authored Sep 4, 2024
1 parent 06116ac commit 48eed07
Show file tree
Hide file tree
Showing 5 changed files with 32 additions and 21 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"eslint-plugin-n": "^16.6.2",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^5.2.1",
"eslint-plugin-promise": "^7.1.0",
"eslint-plugin-promise": "^6.0.0",
"eslint-plugin-react": "^7.35.0",
"eslint-plugin-react-hooks": "^4.4.0",
"husky": "^9.1.3",
Expand Down
1 change: 1 addition & 0 deletions pages/tools/components/ui/DropdownMenu.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export default function DropdownMenu({

<div
className={classnames(
'tools-dropdown-menu',
'ml-0 mt-4 overflow-x-hidden overscroll-y-auto max-h-80',
{ hidden: !isDropdownOpen },
)}
Expand Down
9 changes: 9 additions & 0 deletions pages/tools/hooks/useToolsTransform.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,15 @@ export default function useToolsTransform(tools: JSONSchemaTool[]) {
setTransform(updatedTransform);
}, [router.isReady]);

useEffect(() => {
if (!router.isReady) return;
const { query } = router;

if (Object.keys(query).length === 0) {
resetTransform();
}
}, [router]);

const updateTransform = (update: TransformUpdate) => {
setTransform((prevTransform) => {
const newTransform =
Expand Down
15 changes: 15 additions & 0 deletions styles/globals.css
Original file line number Diff line number Diff line change
Expand Up @@ -274,3 +274,18 @@ border-radius: 4px; */
.no-scroll {
overflow: hidden;
}

.tools-dropdown-menu::-webkit-scrollbar {
width: 0.5rem;
height: 5px;
}

.tools-dropdown-menu::-webkit-scrollbar-track {
background: white;
border-radius: 8px;
}

.tools-dropdown-menu::-webkit-scrollbar-thumb {
background: grey;
border-radius: 8px;
}
26 changes: 6 additions & 20 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2503,13 +2503,6 @@ __metadata:
languageName: node
linkType: hard

"@types/lodash@npm:^4.14.200":
version: 4.14.202
resolution: "@types/lodash@npm:4.14.202"
checksum: 10c0/6064d43c8f454170841bd67c8266cc9069d9e570a72ca63f06bceb484cb4a3ee60c9c1f305c1b9e3a87826049fd41124b8ef265c4dd08b00f6766609c7fe9973
languageName: node
linkType: hard

"@types/node@npm:*":
version: 20.14.12
resolution: "@types/node@npm:20.14.12"
Expand Down Expand Up @@ -3832,7 +3825,7 @@ __metadata:
languageName: node
linkType: hard

"caniuse-lite@npm:^1.0.30001538, caniuse-lite@npm:^1.0.30001541, caniuse-lite@npm:^1.0.30001579":
"caniuse-lite@npm:^1.0.30001541, caniuse-lite@npm:^1.0.30001579":
version: 1.0.30001627
resolution: "caniuse-lite@npm:1.0.30001627"
checksum: 10c0/67d39ca4bead791876c42220b4fe5bd22ba03dbec42f102f0ea9271be3df21bfdb6ba2b0f0dd9eb339eebfc96de3a42a3a5f3fc179ef47229ee5055301217572
Expand Down Expand Up @@ -5214,12 +5207,12 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-promise@npm:^7.1.0":
version: 7.1.0
resolution: "eslint-plugin-promise@npm:7.1.0"
"eslint-plugin-promise@npm:^6.0.0":
version: 6.6.0
resolution: "eslint-plugin-promise@npm:6.6.0"
peerDependencies:
eslint: ^7.0.0 || ^8.0.0 || ^9.0.0
checksum: 10c0/bbc3406139715dfa5f48d04f6d5b5e82f68929d954b0fa3821eb8cd6dc381b210512cedd2d874e5de5381005d316566f4ae046a4750ce3f5f5cbf28a14cc0ab2
checksum: 10c0/93a667dbc9ff15c4d586b0d40a31c7828314cbbb31b2b9a75802aa4ef536e9457bb3e1a89b384b07aa336dd61b315ae8b0aadc0870210378023dd018819b59b3
languageName: node
linkType: hard

Expand Down Expand Up @@ -7164,7 +7157,7 @@ __metadata:
eslint-plugin-n: "npm:^16.6.2"
eslint-plugin-node: "npm:^11.1.0"
eslint-plugin-prettier: "npm:^5.2.1"
eslint-plugin-promise: "npm:^7.1.0"
eslint-plugin-promise: "npm:^6.0.0"
eslint-plugin-react: "npm:^7.35.0"
eslint-plugin-react-hooks: "npm:^4.4.0"
feed: "npm:^4.2.2"
Expand Down Expand Up @@ -10198,13 +10191,6 @@ __metadata:
checksum: 10c0/fdc92bb7b18b31c0e76f8ec4f98d07236b09590fd6578e587ad024792c8b2235d65125a8fd007fa47a84400f84ceccbf33f24e5198d953249e7204f4cef3517c
languageName: node
linkType: hard

"tslib@npm:^1.10.0":
version: 1.14.1
resolution: "tslib@npm:1.14.1"
checksum: 10c0/69ae09c49eea644bc5ebe1bca4fa4cc2c82b7b3e02f43b84bd891504edf66dbc6b2ec0eef31a957042de2269139e4acff911e6d186a258fb14069cd7f6febce2
languageName: node
linkType: hard

"tslib@npm:^2.0.3, tslib@npm:^2.1.0":
version: 2.6.3
Expand Down

0 comments on commit 48eed07

Please sign in to comment.