build: add type definitions #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougwilson
reviewed
Jan 20, 2023
types/index.d.ts
Outdated
| * | ||
| * The `types` array can contain full MIME types or file extensions. Any value that is not a full MIME types is passed to `require('mime-types').lookup`. | ||
| */ | ||
| type(types: string[]): string[] | string | string[] | false; |
There was a problem hiding this comment.
Does having string[] listed twice do something special or just a typo (sorry, only passiingly-familiar with type script)?
There was a problem hiding this comment.
sorry my fault. realized that the types in @types/accepts doesnt match what the library returns. so i was curious if these types could be just shipped by the library itself.
|
Isn't that already covered by |
|
I agree with @pke, seems like https://www.npmjs.com/package/@types/accepts is covering this gap. |
|
Based on expressjs/typescript-wg#1 seems like the current approach is to let types outside of the repositories. |
|
@UlisesGascon should we close this PR then? |
|
Apologies I closed the PR by mistake when trying to comment 🤦🏻♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.