Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: setting data for adopted probes #442

Merged
merged 37 commits into from
Nov 23, 2023
Merged

feat: setting data for adopted probes #442

merged 37 commits into from
Nov 23, 2023

Conversation

alexey-yarmosh
Copy link
Member

Fixes #427

@alexey-yarmosh
feat: ignore syncing of custom fields
46daf4d
@alexey-yarmosh
refactor: move fetch sockets from ws server
17f6b53
@alexey-yarmosh
test: fix tests
99cbd3d
@alexey-yarmosh
refactor: rename fetchsockets
ebecf27
@alexey-yarmosh
feat: update probe info with custom data
c061e6b
@alexey-yarmosh
feat: add index values
c385ee3
@alexey-yarmosh
feat: get username from dashboard
b7918b8
@alexey-yarmosh
test: fix tests
e168747
@alexey-yarmosh
feat: return probe info after send code to the probe
0901416
@alexey-yarmosh
fix: fix filtering by user tags
9afb005
@alexey-yarmosh
fix: fix test ts build
30843af
@alexey-yarmosh
feat: log and send to the probe updated location
3db1172
@alexey-yarmosh
fix: tests
4908747
@alexey-yarmosh
feat: do not apply adoption city data if country doesn`t match
46073ab
@alexey-yarmosh
fix: test db
ce47ad2
@alexey-yarmosh
fix: update init sql script
b876926
@alexey-yarmosh
test: add GET int test
4b65b98
@alexey-yarmosh
fix: nock geo ip
fa9d0a9
@alexey-yarmosh
test: add adoption POST test
8ff9d32
@alexey-yarmosh
test: add adopted-probes tests
56f764d
@alexey-yarmosh
test: add more adopted sockets tests
0095bcd
@alexey-yarmosh
feat: update state of the adopted probes in US cities
08517b6
@alexey-yarmosh
feat: update gihtub ci
0321498
@alexey-yarmosh
feat: use github field instead of last_name field
d9d7380
@alexey-yarmosh
test: update userId value
7d1b4b1
@alexey-yarmosh
fix: treat null and undefined values as equal
f8145c4
@alexey-yarmosh
refactor: update sql query
8b3e219
MartinKolarik
MartinKolarik reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not finished with the review yet, but submitting what I have so far.

src/lib/adopted-probes.ts Outdated Show resolved Hide resolved
src/probe/builder.ts Show resolved Hide resolved
MartinKolarik
MartinKolarik reviewed Nov 15, 2023
View reviewed changes
src/lib/geoip/utils.ts Outdated Show resolved Hide resolved
test/tests/unit/probe/router.test.ts Show resolved Hide resolved
@alexey-yarmosh alexey-yarmosh force-pushed the custom-data branch 2 times, most recently from 41f4e59 to 8b19efb Compare November 22, 2023 16:35
@alexey-yarmosh
Copy link
Member Author

Updated to handle the adopted country change, @MartinKolarik please review.

@MartinKolarik MartinKolarik merged commit cc03c96 into master Nov 23, 2023
2 checks passed
@MartinKolarik MartinKolarik deleted the custom-data branch November 23, 2023 15:51
@alexey-yarmosh alexey-yarmosh mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKolarik MartinKolarik MartinKolarik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting data for adopted probes
2 participants
@alexey-yarmosh @MartinKolarik