Skip to content

Comments

Changed package name#2

Open
edworboys wants to merge 2 commits intojsakas:masterfrom
edworboys:fix-pypi
Open

Changed package name#2
edworboys wants to merge 2 commits intojsakas:masterfrom
edworboys:fix-pypi

Conversation

@edworboys
Copy link

A package already exists on pypi named 'beatport' meaning this package cannot be published.

At the same time I noticed all the requirements were not present in the setup file, so I added an automated parser.

Finally, without a license, this can't be used to so I suggest MIT, but open to suggestions.

@jsakas
Copy link
Owner

jsakas commented Nov 10, 2015

Hey @edworboys, thanks for the PR!

When I pull down this branch and try to install on a fresh virtualenv, I'm getting this error:

$ python setup.py install
Traceback (most recent call last):
  File "setup.py", line 11, in <module>
    requirements = parse_requirements('requirements.txt')
  File "setup.py", line 8, in parse_requirements
    [line.strip() for line in open(filename).readlines()]))
  File "setup.py", line 7, in <lambda>
    return list(filter(lambda line: (line.strip())[0] != '#',
IndexError: string index out of range

@edworboys
Copy link
Author

Hi @jsakas,

Sorry, I didn't test the parser with your requirements.txt file. It didn't like the empty lines. Now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants