Support Node 22 & 23 #331
Merged
Support Node 22 & 23 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the default script timeout for Test262 from 30s to 60s to accommodate longer tests we now have. By changing this timeout in `runtest262.mjs` instead of `npm run test262`, we restore the ability for an IDE debugger like VS Code to use `npm run test262` with a longer `TIMEOUT` environment variable to ensure that debug sessions can be much longer than one minute.
justingrant
force-pushed
the
node-23
branch
3 times, most recently
from
bd2c7df to
dc22448
Compare
justingrant
force-pushed
the
node-23
branch
3 times, most recently
from
23d6854 to
8aba37c
Compare
Updates tests to handle Node 22 & 23, including newly-working tests. Also removes expected-failure references to a few tests that were removed recently.
The previous commit 19b00b2 was a bit too overzealous in removing saving primordials, because saving was actually needed in the case of `DurationFormat`'s `format` and `formatToParts` methods. This commit restores saving these methods before we polyfill them.
In Node 23, offset time zone IDs are now supported by `Intl.DateTimeFormat`. This commit changes the polyfill to handle these IDs.
ptomato
approved these changes
Mar 31, 2025
Comment on lines
-9
to
-10
| # temporal-test262-runner doesn't support the $262 global object | ||
| intl402/DateTimeFormat/proto-from-ctor-realm.js |
There was a problem hiding this comment.
Note, I added this in #282 in order to be able to support js-temporal/temporal-test262-runner#19, but then we decided to stick to npm releases of temporal-test262-runner only. When we update temporal-test262-runner, we'll need to add this back in.
This was referenced Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support Node 22 & 23. In addition to changing expected failures files for bugs that Node fixed, there were two Node changes that required polyfill code changes:
Intl.DurationFormat, and this PR fixes an infinite recursive loop (accidentally introduced in 19b00b2) that occurred if a nativeIntl.DurationFormatwas present.Fixes #323.