-
Notifications
You must be signed in to change notification settings - Fork 0
Fix CI matrix.name literal display in skipped jobs #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
User request: "address problems in actions where we see 'Test ${{ matrix.name }}'"
Co-Authored-By: Claude <[email protected]>
🧪 CI InsightsHere's what we observed from your CI run for 0be2d92. 🟢 All jobs passed!But CI Insights is watching 👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatically approving PR from repo owner
Merge Queue Status🚫 The pull request has left the queue (rule: This pull request spent 4 minutes 43 seconds in the queue, with no time running CI. ReasonThe pull request #281 has been manually updated HintIf you want to requeue this pull request, you can post a |
User request: "have some better github action summarization to help debug matrix expansion" Co-Authored-By: Claude <[email protected]>
|
The PR Status Check has failed. Please review the CI logs and fix any issues. Common issues:
You can run checks locally: task test-parallel-fast # Run tests
task lint-parallel # Run linters
uv run tooling/validate_docs.py # Validate docs |
User request: "look into integration tests being skipped during CI" - Update ci_matrix.py to trigger integration tests for: - tests/integration/ changes - pkg/plugin/ changes (core SDK) - pkg/drivers/ changes (all drivers) - patterns/ changes - cmd/ changes - Apply step-level conditions to test-integration job for consistent UI - Add step summary showing execution decision for integration tests Co-Authored-By: Claude <[email protected]>
User request: "ensure that rust integration tests are also properly triggered by the CI matrix" - Update ci_matrix.py to trigger test:unit-proxy for all prism-proxy changes - Trigger test:integration-rust for prism-proxy/src/ and prism-proxy/tests/ changes - Add Rust integration tests step to test-proxy job - Apply step-level conditions to test-proxy for consistent CI visibility - Add step summary showing execution decision for Rust tests Co-Authored-By: Claude <[email protected]>
|
The PR Status Check has failed. Please review the CI logs and fix any issues. Common issues:
You can run checks locally: task test-parallel-fast # Run tests
task lint-parallel # Run linters
uv run tooling/validate_docs.py # Validate docs |
User request: "fix ci issues"
Use grouped redirects { ...; } >> file instead of individual echo redirects
to satisfy shellcheck SC2129 style requirement.
Co-Authored-By: Claude <[email protected]>
|
The PR Status Check has failed. Please review the CI logs and fix any issues. Common issues:
You can run checks locally: task test-parallel-fast # Run tests
task lint-parallel # Run linters
uv run tooling/validate_docs.py # Validate docs |
Merge Queue Status✅ The pull request has been merged at 0be2d92 This pull request spent 14 minutes 46 seconds in the queue, including 8 minutes 48 seconds running CI. Required conditions to merge
|
Summary
Test ${{ matrix.name }}appeared literally in GitHub Actions UI when jobs were skippedifconditions that prevented proper job name displayci_matrix.pyto properly trigger integration tests (Go and Rust)Root Cause
When a GitHub Actions job with a matrix strategy has a job-level
ifcondition that evaluates to false, the job is skipped before the matrix is expanded. This causes the literal expression${{ matrix.name }}to appear in the UI instead of the expanded value.Additionally, integration tests (both Go and Rust) were being skipped too aggressively because
ci_matrix.pydidn't include proper test triggers for many code paths.Solution
Job Display Fix
Move the skip logic from job-level to step-level:
ifcondition), ensuring matrix is expandedif: steps.should-run.outputs.run == 'true'conditionsGo Integration Test Triggers
Updated
ci_matrix.pyto triggertest:integrationfor:tests/integration/changespkg/plugin/changes (core SDK)pkg/drivers/changes (all drivers including memstore)patterns/changescmd/changesRust Integration Test Triggers
Updated
ci_matrix.pyto trigger Rust tests:test:unit-proxyfor allprism-proxy/changestest:integration-rustforprism-proxy/src/andprism-proxy/tests/changesAdded Rust integration tests step to
test-proxyjob that runs:cargo test --test integration_test -- --ignored --nocaptureStep Summaries
Added GitHub Step Summaries showing:
Test plan