Skip to content

Conversation

@jrepp
Copy link
Owner

@jrepp jrepp commented Nov 17, 2025

Address Copilot review comments:

  1. Remove unused doc_type parameter from ensure_required_fields()

    • Simplified function signature by removing unused parameter
    • Updated all call sites in whitespace.py and tests
    • Removed doc_type detection logic since it wasn't being used
  2. Remove hardcoded test count badge from README

    • Removed "628 tests passing" badge that required manual updates
    • Badge was error-prone and would become stale
    • Coverage badge and CI badge already show test health

All tests passing (628 passed, 1 skipped)

🤖 Generated with Claude Code

Address Copilot review comments:

1. Remove unused doc_type parameter from ensure_required_fields()
   - Simplified function signature by removing unused parameter
   - Updated all call sites in whitespace.py and tests
   - Removed doc_type detection logic since it wasn't being used

2. Remove hardcoded test count badge from README
   - Removed "628 tests passing" badge that required manual updates
   - Badge was error-prone and would become stale
   - Coverage badge and CI badge already show test health

All tests passing (628 passed, 1 skipped)

Co-Authored-By: Copilot <[email protected]>

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Copilot AI review requested due to automatic review settings November 17, 2025 08:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses code review feedback by removing an unused parameter and a static badge. The changes simplify the codebase by eliminating the doc_type parameter from ensure_required_fields() since it was never actually used in the function logic, and remove a hardcoded test count badge that required manual maintenance.

  • Removed unused doc_type parameter from ensure_required_fields() function
  • Updated all function call sites to match new signature
  • Removed hardcoded test count badge from README

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
docuchango/fixes/whitespace.py Simplified function signature and removed doc_type detection logic
tests/test_whitespace_fixes.py Updated function calls to remove doc_type argument
tests/test_whitespace_comprehensive.py Updated function calls and renamed test for clarity
README.md Removed static test count badge

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.65%. Comparing base (dd7a71d) to head (e5e6b47).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   61.59%   61.65%   +0.06%     
==========================================
  Files          23       23              
  Lines        2924     2929       +5     
  Branches      544      541       -3     
==========================================
+ Hits         1801     1806       +5     
- Misses       1060     1062       +2     
+ Partials       63       61       -2     
Flag Coverage Δ
unittests 61.65% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
docuchango/fixes/whitespace.py 95.45% <100.00%> (+5.65%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd7a71d...e5e6b47. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jrepp jrepp merged commit 7a39e84 into main Nov 17, 2025
8 checks passed
Copy link
Contributor

Copilot AI commented Nov 17, 2025

@jrepp I've opened a new pull request, #38, to work on those changes. Once the pull request is ready, I'll request review from you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants