Support for deferred proxies using JImplements #656
Conversation
Codecov Report
@@ Coverage Diff @@
## master #656 +/- ##
==========================================
- Coverage 78.52% 78.39% -0.14%
==========================================
Files 118 118
Lines 8755 8774 +19
Branches 3715 3715
==========================================
+ Hits 6875 6878 +3
- Misses 1373 1389 +16
Partials 507 507
Continue to review full report at Codecov.
|
Thrameos
added
the
enhancement
|
|
||
| # Return the augmented class | ||
| return type("proxy.%s" % cls.__name__, (cls, _jpype._JProxy), members) | ||
| if _jpype.isStarted(): |
There was a problem hiding this comment.
Given the conversation at #504 I'm not sure JVM is started is the right test for deciding whether we should be doing interface/override checking. I rather think explicit control is a good thing here.
There was a problem hiding this comment.
We do interface and override checking regardless. If it is prior to starting then checking is done at the first create, else we execute it immediately.
| return actualIntf | ||
|
|
||
| def new(tp, *args, **kwargs): | ||
| actualIntf = init(cls) |
There was a problem hiding this comment.
It would be good to only do this once, as we do with the non deferred case.
There was a problem hiding this comment.
I believe line 49 ensures we do this only once.
|
I also took a shot at this in #659. |
In tonight's endless PR, we change the pattern for proxy creation so that classes can implement interfaces before the JVM is actually started. Proxies created in this fashion are not actually checked until the first object using the Proxy is created, but are otherwise the same as normal proxies.
Fixes #653