Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Swift 5.9 #810

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Support for Swift 5.9 #810

merged 1 commit into from
Feb 27, 2024

Conversation

johnfairh
Copy link
Collaborator

@johnfairh johnfairh commented Feb 26, 2024

First step to adding Swift 5.10 support....

Co-authored-by: Marcos Griselli <[email protected]>
@johnfairh johnfairh marked this pull request as ready for review February 27, 2024 10:50
@@ -71,7 +71,7 @@ public enum SwiftDeclarationAttributeKind: String, CaseIterable {
case setterPublic = "source.decl.attribute.setter_access.public"
case setterOpen = "source.decl.attribute.setter_access.open"
case optimize = "source.decl.attribute._optimize"
case consuming = "source.decl.attribute.__consuming"
case __consuming = "source.decl.attribute.__consuming"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In conjunction with the new 'real' consuming attribute this rename is a bit dodgy, open to suggestions...

Copy link
Owner

@jpsim jpsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I know Xcode / Swift updates are tedious but I appreciate the work here.

@jpsim jpsim merged commit 998aefe into jpsim:main Feb 27, 2024
13 checks passed
@johnfairh johnfairh deleted the jf-swift59 branch February 27, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants