Move ingest creation to context object#655
Open
feaster83 wants to merge 5 commits intojprante:masterfrom
Open
Conversation
feaster83
added a commit
to feaster83/elasticsearch-jdbc-river-rebuild-strategy
that referenced
this pull request
Oct 13, 2015
…ill unmerged so compilation will fail).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We move the ingest creation to the context object. We think that this approach is better because there will be a single point of ingest creation and control.
That makes it also easier to share the ingest to other parts of the implementation. We did tests and the code works as expected. Even we didn't found any resource leaks (checked with VisualVM).