Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DateInput when DatePicker is disabled #4734

Merged
merged 5 commits into from
Feb 25, 2025

Conversation

alexmotoc
Copy link
Contributor

Closes #4730

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: b7cd6c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/lab Minor
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 20, 2025

@alexmotoc is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@mark-tate
Copy link
Contributor

LGTM - we could look at adding a disabled and readOnly state to the QA examples

mark-tate
mark-tate previously approved these changes Feb 22, 2025
@mark-tate mark-tate added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 22, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 22, 2025
@alexmotoc
Copy link
Contributor Author

LGTM - we could look at adding a disabled and readOnly state to the QA examples

Sounds good, happy to add as part of this PR or could do it separately

@joshwooding
Copy link
Contributor

LGTM - we could look at adding a disabled and readOnly state to the QA examples

Sounds good, happy to add as part of this PR or could do it separately

Can you do it part of this PR please 🙏

@joshwooding joshwooding force-pushed the disable-date-picker-input branch from c08dd44 to b7cd6c8 Compare February 25, 2025 12:18
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 25, 2025
Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:24am

@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 25, 2025
@Fercas123 Fercas123 merged commit b619a9d into jpmorganchase:main Feb 25, 2025
14 of 15 checks passed
@alexmotoc alexmotoc deleted the disable-date-picker-input branch February 25, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled Date Picker is still interactive
4 participants