Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tab overflow behaviour and accessibility #4732

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

joshwooding
Copy link
Contributor

@joshwooding joshwooding commented Feb 19, 2025

Improved Tab's overflow behavior and accessibility:

  • Tab lists should now collapse in more scenarios.
  • Tabs selected from the overflow menu should be focused more consistently.
  • When a tab is removed, focus moved to the next tab in the tab list more consistently.
  • When a selected tab is removed, the next tab in the tab list should be selected more consistently.

Relevant stories

https://jpmorganchase-investigate-ta.saltdesignsystem-storybook.pages.dev/?path=/story/lab-tabs-next--controlled

Steps to test

Click the remove button on tab and the next tab should be focused. If the tab was selected the next tab should be selected

Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 87fb7ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/lab Patch
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 11:22am

@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 8b047da to 18e8a1c Compare February 19, 2025 19:24
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 18e8a1c to ff4924c Compare February 19, 2025 20:38
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from ff4924c to bdc2df9 Compare February 21, 2025 11:25
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from bdc2df9 to 280e22c Compare February 21, 2025 11:46
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 280e22c to 446cde3 Compare February 23, 2025 11:30
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 446cde3 to 977947f Compare February 23, 2025 12:58
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 977947f to 105b856 Compare February 23, 2025 13:21
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 105b856 to fbdf465 Compare February 23, 2025 15:52
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from fbdf465 to da69fcc Compare February 23, 2025 16:15
@joshwooding joshwooding changed the title Investigate tab resize Improve Tab overflow behaviour and accessibility Feb 24, 2025
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 87d0c0c to df482e5 Compare February 24, 2025 09:10
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from df482e5 to 0eccdc5 Compare February 25, 2025 23:15
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 25, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 25, 2025
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 25, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 26, 2025
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 96c3fb8 to 43c3af9 Compare February 26, 2025 08:00
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from ef1f474 to 87fb7ec Compare February 26, 2025 22:21
@joshwooding joshwooding marked this pull request as ready for review February 26, 2025 22:22
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 26, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 26, 2025
@joshwooding joshwooding force-pushed the investigate-tab-resize branch from 87fb7ec to 02fefe6 Compare February 27, 2025 11:14
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 27, 2025
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Feb 27, 2025
@joshwooding joshwooding merged commit 076dedd into main Feb 27, 2025
14 of 15 checks passed
@joshwooding joshwooding deleted the investigate-tab-resize branch February 27, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants