Slider update #4614

tayyabataimur · 2025-01-23T11:54:19Z

No description provided.

changeset-bot · 2025-01-23T11:54:24Z

⚠️ No Changeset found

Latest commit: 1a111ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-01-23T11:54:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
saltdesignsystem	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 7, 2025 0:44am

.yarnrc.yml

packages/lab/src/custom-slider/CustomSlider.tsx

packages/lab/src/slider/Slider.css

joshwooding · 2025-02-07T11:37:12Z

packages/lab/src/slider/internal/SliderTrack.tsx

+        </div>
+        {/* Max label */}
+        {!markers && (
+          <Text as="label" className={withBaseName("maxLabel")}>


Suggested change

<Text as="label" className={withBaseName("maxLabel")}>

<Text styleAs="label" className={withBaseName("maxLabel")}>

Worth checking with @jake-costa but right now markers are <label> elements.

joshwooding · 2025-02-07T11:37:25Z

packages/lab/src/slider/internal/SliderTrack.tsx

+                    } as React.CSSProperties
+                  }
+                  key={marker.value}
+                  as="label"


Suggested change

as="label"

styleAs="label"

tayyabataimur force-pushed the slider-update branch 2 times, most recently from 1eee83a to a2508f9 Compare January 23, 2025 11:57

joshwooding reviewed Jan 23, 2025

View reviewed changes

.yarnrc.yml Outdated Show resolved Hide resolved

vercel bot had a problem deploying to Preview January 23, 2025 12:14 Failure

tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 23, 2025

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 23, 2025

vercel bot had a problem deploying to Preview January 24, 2025 10:28 Failure

tayyabataimur added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 24, 2025

vercel bot had a problem deploying to Preview January 24, 2025 10:37 Failure

vercel bot had a problem deploying to Preview January 24, 2025 10:46 Failure

tayyabataimur added chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. and removed chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. labels Jan 24, 2025

github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jan 24, 2025

vercel bot had a problem deploying to Preview January 24, 2025 11:30 Failure

joshwooding self-requested a review January 24, 2025 11:31