-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI #132
Fix CI #132
Conversation
It seems that the Binder Badge fails this time because it is before the merge. |
Thanks for looking into this! I'm probably going to move everything to GitHub actions, but I will reuse these commits when I do that. |
Thank you for your prompt comments. |
By the way, does the problem @telamonian mentioned in the comment here go away with the move to GitHub Actions? I would like to know if there are any policy or progress updates on the move to GitHub Action, as I have worked on this as I still think the current CI configuration is useful. |
@telamonian I'm +1 on this for now pending your review, I'm going to work a bit on jupyterfs again but I don't have time to move to GitHub actions yet. |
@reoono feel free to add yourself here https://github.com/jpmorganchase/jupyter-fs/blob/main/AUTHORS |
Thank you for your kind words. |
References
Fixes #121
Summary
Binder Badge
After checking the official Binder documentation, I found that the permissions were not set properly.
The format was referred to the
ipywidget
repository.https://github.com/jupyter-widgets/ipywidgets/blob/88cec8be2869e75760a6a99bba129e6011d9043f/.github/workflows/binder-on-pr.yml#L7
Azure Pipeline
macOS-10.14 images were no longer available. Therefore, I modified it to use the latest image.
https://devblogs.microsoft.com/devops/hosted-pipelines-image-deprecation/
However, the new image was failing to install Docker, so I corrected the relevant step based on the following comment.
docker/for-mac#2359 (comment)
Appveyor
The installation of
pywinpty
was failing due to a newer version of Python. Therefore, the necessary dependencies were added to the installation.Also, when the installation error was resolved,
NotConnected
error occurred in Test_FSManager_smb_os_share.While verifying with RDP, in the following URI, the hostname was
appveyor-vm.appveyor.local
.When I corrected hostname to
appveyor
, the connection was established.So I modified to use gethostname() instead of getfqdn().