Skip to content

Proposal of fix for kernel segfault #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
helloIAmPau wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Proposal of fix for kernel segfault #116

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
08250c8
Fix segfault
helloIAmPau Jan 14, 2015
7186a02
forcing row length to 80 chars (more on less)
helloIAmPau Apr 3, 2015
1866ae1
multiline
Apr 3, 2015
50140c3
Changing IFS to UIFS
helloIAmPau May 11, 2015
372ebf6
checking by using the petazzo way
helloIAmPau Jun 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pipework
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,13 @@ else
}
fi

# This avoids segfault when pipework is called twice on the same container
[ -L /sys/class/net/${IFNAME}/upper_ph${NSPID}${CONTAINER_IFNAME} ] &&
echo "A bridge on ${CONTAINER_IFNAME} already exists for ${GUESTNAME}" &&
IFS=$(ls /sys/class/net/${IFNAME}/upper_ph${NSPID}* | sed "s/\/sys\/class\/net\/${IFNAME}\/upper_ph${NSPID}//g") &&
Copy link
Owner

@jpetazzo jpetazzo May 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I think we shouldn't use IFS, since it's a built-in variable :-)

I'm not sure I understand the goal of that line... Can you explain what it does? It should list the content of a directory, but I don't understand why, sorry!

echo "$IFS\nare already taken" &&
exit 1

# Check if an incompatible VLAN device already exists
[ $IFTYPE = phys ] && [ "$VLAN" ] && [ -d /sys/class/net/$IFNAME.VLAN ] && {
[ -z "$(ip -d link show $IFNAME.$VLAN | grep "vlan.*id $VLAN")" ] && {
Expand Down