-
Notifications
You must be signed in to change notification settings - Fork 33
Fix strict concurrency warnings #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @kevin-kp! Great work 💯 couple Qs for you - (caveat - I haven't dived into Regarding JSONEncoder - would a |
|
LGTM - feel free to change from Draft to Open and I'll approve |
# Conflicts: # Papyrus/Sources/PapyrusRequest.swift # Papyrus/Sources/PapyrusResponse.swift
|
@joshuawright11 it actually isn't ready yet as the Provider is still not Sendable (which i'm currently getting warnings from). |
|
@joshuawright11 sorry for the delay, I had doubts of making provider an actor so I created a mutex instead. |
|
Any updates to this PR? @kevin-kp @joshuawright11 do you guys need any help? |
|
@lutes1 |
|
Ah, do you mind creating another PR from your main branch? Maybe we can get @joshuawright11 to merge it and continue to maintain this repo. I think it's important for this repo to succeed considering the state of api clients in Swift |
|
Closing this PR in favor of #72 |
This PR is an effort to fix the strict concurrency warnings when adding the swift setting
StrictConcurrency(not included in the commit).You can test this by adding the following to the necessary targets:
The only two warnings that are left are
HTTPBodyEncoderandHTTPBodyDecoder.This is because Sendable conformance is iOS >= 16.0 for JSONEncoder and JSONDecoder and I'm not sure what the best approach is to resolve these two warnings.