Skip to content

refactor(test): simplify loops and status checks #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshua-sajeev merged 1 commit into from
Nov 23, 2025
Merged

refactor(test): simplify loops and status checks #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions internal/middleware/ratelimiter/rate_limiter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,16 @@ func TestMiddleware_RateLimitsRequests(t *testing.T) {
rateLimitedCount := 0

// Make 5 rapid requests
for i := 0; i < 5; i++ {
for range 5 {
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
req.RemoteAddr = "192.168.1.1:1234" // Same IP for all requests
r.ServeHTTP(w, req)

if w.Code == http.StatusOK {
switch w.Code {
case http.StatusOK:
successCount++
} else if w.Code == http.StatusTooManyRequests {
case http.StatusTooManyRequests:
rateLimitedCount++
}
}
Expand Down Expand Up @@ -125,7 +126,7 @@ func TestMiddleware_DifferentIPs(t *testing.T) {

for _, ip := range ips {
// Each IP should get 2 successful requests (burst)
for i := 0; i < 2; i++ {
for range 2 {
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
req.RemoteAddr = ip
Expand Down