feat(cdp): signal when the ref list is truncated in look()#18
Open
nipunrajk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
truncatedCountincompactAxTreeby continuing the loop to count matching elements after theMAX_REFSlimit is reached.look()text output when truncated:\n… N more elements below — scroll or filter.truncatedCountinsnapshot.test.ts.Why
Fixes #2. Prevents the LLM agent from assuming it has captured the entire page when the element list is truncated, letting it know it needs to scroll or filter.
Checklist
pnpm testandpnpm -r typecheckpass