#115 chore: added wireguard exceptions and auxiliary methods to check…

… if an interface is up or down

Linguard/Core/Services/Exceptions/WireguardException.cs

@@ -0,0 +1,7 @@
+namespace Linguard.Core.Services.Exceptions; 
+
+public class WireguardException : Exception {
+    public WireguardException() {}
+    public WireguardException(string message) : base(message) {}
+    public WireguardException(string message, Exception innerException) : base(message, innerException) {}
+}

Linguard/Core/Services/IWireguardService.cs

@@ -6,6 +6,8 @@ namespace Linguard.Core.Services;
 
 public interface IWireguardService {
     Interface? GetInterface(Client client);
+    bool IsInterfaceUp(Interface iface);
+    bool IsInterfaceDown(Interface iface);
     void StartInterface(Interface @interface);
     void StopInterface(Interface @interface);
     string? GenerateWireguardPrivateKey();

Linguard/Core/Services/WireguardService.cs

@@ -1,12 +1,11 @@
-using System.Linq.Expressions;
-using System.Net.NetworkInformation;
+using System.Net.NetworkInformation;
 using System.Text;
-using System.Text.RegularExpressions;
 using Linguard.Core.Configuration;
 using Linguard.Core.Managers;
 using Linguard.Core.Models;
 using Linguard.Core.Models.Wireguard;
 using Linguard.Core.OS;
+using Linguard.Core.Services.Exceptions;
 using Linguard.Core.Utils;
 
 namespace Linguard.Core.Services; 
@@ -25,26 +24,39 @@ public WireguardService(IConfigurationManager configurationManager, ICommandRunn
     public Interface? GetInterface(Client client) => Configuration.Interfaces
         .SingleOrDefault(i => i.Clients.Contains(client));
 
+    public bool IsInterfaceUp(Interface iface) {
+        return NetworkInterface.GetAllNetworkInterfaces()
+            .Any(i => i.Name.Equals(iface.Name) && i.OperationalStatus == OperationalStatus.Up);
+    }
+
+    public bool IsInterfaceDown(Interface iface) {
+        return !IsInterfaceUp(iface);
+    }
+
     public void StartInterface(Interface @interface) {
         var result = _commandRunner
             .Run($"sudo {Configuration.WireguardQuickBin} up {@interface.Name}");
-        if (!result.Success) throw new Exception(result.Stderr);
+        if (!result.Success) throw new WireguardException(result.Stderr);
     }
 
     public void StopInterface(Interface @interface) {
         var result = _commandRunner
             .Run($"sudo {Configuration.WireguardQuickBin} down {@interface.Name}");
-        if (!result.Success) throw new Exception(result.Stderr);
+        if (!result.Success) throw new WireguardException(result.Stderr);
     }
 
     public string? GenerateWireguardPrivateKey() {
-        return _commandRunner
-            .Run($"sudo {Configuration.WireguardBin} genkey").Stdout;
+        var result = _commandRunner
+            .Run($"sudo {Configuration.WireguardBin} genkey");
+        if (!result.Success) throw new WireguardException(result.Stderr);
+        return result.Stdout;
     }
 
     public string? GenerateWireguardPublicKey(string privateKey) {
-        return _commandRunner
-            .Run($"echo {privateKey} | sudo {Configuration.WireguardBin} pubkey").Stdout;
+        var result = _commandRunner
+            .Run($"echo {privateKey} | sudo {Configuration.WireguardBin} pubkey");
+        if (!result.Success) throw new WireguardException(result.Stderr);
+        return result.Stdout;
     }
 
     public string[] GenerateOnUpRules(string interfaceName, NetworkInterface gateway) {
@@ -81,8 +93,7 @@ public DateTime GetLastHandshake(Client client) {
             return WireguardDumpParser.GetLastHandshake(rawData, client);
         }
         catch (Exception e) {
-            // TODO: log
-            return default;
+            throw new WireguardException($"Unable to obtain last handshake for client {client.Name}", e);
         }
     }
 
@@ -103,10 +114,9 @@ public IEnumerable<TrafficData> GetTrafficData(Interface iface) {
         var rawData = _commandRunner
             .Run($"{Configuration.WireguardBin} show {iface.Name} dump")
             .Stdout;
-        if (string.IsNullOrEmpty(rawData)) {
-            return Enumerable.Empty<TrafficData>();
-        }
-        return WireguardDumpParser.GetTrafficData(rawData, iface);
+        return string.IsNullOrEmpty(rawData) 
+            ? Enumerable.Empty<TrafficData>() 
+            : WireguardDumpParser.GetTrafficData(rawData, iface);
     }
 
     private string GenerateWireguardConfiguration(Interface @interface) {
@@ -163,7 +173,7 @@ string GetWireguardDns() {
         }
     }
 
-    private string GetWireguardAddress(IWireguardPeer peer) {
+    private static string GetWireguardAddress(IWireguardPeer peer) {
         string address;
         if (peer.IPv4Address != default) {
             address = peer.IPv4Address.ToString();

Linguard/Web/Pages/EditInterface.razor

@@ -37,7 +37,7 @@
     <div class="col">
         <h1 class="mb-3">
             @Title
-            @if (InterfaceNames.Contains(Iface.Name)) {
+            @if (_wireguardService.IsInterfaceUp(Iface)) {
                 <RadzenBadge class="float-end" IsPill="true" Text="up" BadgeStyle="BadgeStyle.Success" />
             }
             else {

Linguard/Web/Pages/Wireguard.razor

@@ -39,7 +39,7 @@
         <RadzenDataGridColumn TItem="Interface" Title="Actions" Resizable="false" 
                               Filterable="false" Sortable="false">
             <Template Context="data">
-                @if (_interfaces.SingleOrDefault(i => i.Name.Equals(data.Name)) == default) {
+                @if (_wireguardService.IsInterfaceUp(data)) {
                     <RadzenButton Icon="play_arrow" ButtonStyle="ButtonStyle.Success" title="Start"
                                   Click="() => StartInterface(data)" />
                 }
@@ -118,12 +118,11 @@
     IConfiguration Configuration => _configurationManager.Configuration;
     ICollection<Interface> _wireguardInterfaces;
     ICollection<Client> _clients;
-    ICollection<NetworkInterface> _interfaces;
     bool _startingAll;
     bool _stoppingAll;
 
     protected override void OnInitialized() {
-        _interfaces = NetworkInterface.GetAllNetworkInterfaces();
+        NetworkInterface.GetAllNetworkInterfaces();
         _wireguardInterfaces = Configuration.Wireguard.Interfaces
             .OrderBy(i => i.Name)
             .ToList();
@@ -132,14 +131,9 @@
             .ToList();
     }
 
-    void RefreshNetworkInterfaces() {
-        _interfaces = NetworkInterface.GetAllNetworkInterfaces();
-    }
-
     void StartInterface(Interface iface) {
         try {
             _wireguardService.StartInterface(iface);
-            RefreshNetworkInterfaces();
             _interfacesGrid.Reload();
         }
         catch (Exception e) {
@@ -154,7 +148,6 @@
     void StopInterface(Interface @interface) {
         try {
             _wireguardService.StopInterface(@interface);
-            RefreshNetworkInterfaces();
             _interfacesGrid.Reload();
         }
         catch (Exception e) {