support inline directive at anonymous function assignments#20
Open
mgartner wants to merge 2 commits into
Open
Conversation
The `//gcassert:inline` directive already works for callsites of anonymous functions. This commit adds tests for this case.
mgartner
force-pushed
the
anonymous-funcs
branch
from
5354dbc to
fe6ce04
Compare
The `//gcassert:inline` directive can now be used at assignments of anonymous functions to local variables.
mgartner
force-pushed
the
anonymous-funcs
branch
from
fe6ce04 to
cc062a6
Compare
yuzefovich
reviewed
Jan 6, 2025
yuzefovich
left a comment
yuzefovich
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! LGTM, but the CI is red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
//gcassert:inlinedirective can now be used at assignments ofanonymous functions to local variables.