Skip to content

Migrator empty values handling #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −0
Open

Migrator empty values handling #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions code/libraries/joomlatools-components/migrator/migrator/behavior/import/insert.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ protected function _insertCSV(SplFileObject $file, $table, $offset = 0, $limit =
$rows_per_query = 20;
$queue_count = 0;
$total_count = 0;
$columns = array();

foreach ($file as $i => $row)
{
Expand All @@ -136,6 +137,15 @@ protected function _insertCSV(SplFileObject $file, $table, $offset = 0, $limit =

$query->columns($row);

$schema = $this->getObject('lib:database.table.default', array('name' => $table))->getSchema();

foreach ($row as $column)
{
if (isset($schema->columns[$column])) {
$columns[] = $schema->columns[$column];
}
}

continue;
}

Expand All @@ -147,6 +157,8 @@ protected function _insertCSV(SplFileObject $file, $table, $offset = 0, $limit =

$this->_convertNullDates($row);

$this->_convertEmptyValues($row, $columns);

$query->values($row);
$total_count++;
$queue_count++;
Expand All @@ -171,6 +183,25 @@ protected function _insertCSV(SplFileObject $file, $table, $offset = 0, $limit =
return $total_count;
}

protected function _convertEmptyValues(&$row, $columns)
{
$types = array('int', 'bigint', 'tinyint', 'mediumint', 'smallint', 'time', 'timestamp', 'year', 'date', 'datetime'); // A list of allowed types for the conversion

foreach ($row as $key => $value)
{
if (isset($columns[$key]))
{
$default = $columns[$key]->default;
$required = $columns[$key]->required;
$type = $columns[$key]->type;

if ($value === '' && $default === null && !$required && in_array($type, $types)) {
$row[$key] = null;
}
}
}
}

protected function _convertNullDates(&$row)
{
foreach ($row as $i => $value) {
Expand Down