-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[6.0] Fix article version history frontend #46358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 6.0-dev
Are you sure you want to change the base?
[6.0] Fix article version history frontend #46358
Conversation
|
@joomdonation Can you close the corresponding issue when having created a PR for it? |
|
@richard67 Yes, I always do that :) |
@joomdonation Thanks. I've asked because not all maintainers do that. |
|
Update 6.0.0 to 6.0.1-dev+pr.46358 |
|
@dpollez Thanks. Could you please go to https://issues.joomla.org/tracker/joomla-cms/46358 and mark your test result? |
|
@dpollez Please go to the issue tracker here https://issues.joomla.org/tracker/joomla-cms/46358 and mark your test result by using the blue "Test this" button at the top left corner, selecting your test result and then submitting. Each pull request needs 2 successful human test, and marking the test result makers sure that the test is properly counted. Thanks in advance. |
|
I have tested this item ✅ successfully on f9a1c56 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358. |
|
I came across this "version error" while checking whether PR 45254 had been fixed in version 6, which unfortunately wasn't. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358. |
I haven't looked at that one, so I don't know. Usually, thing with routing is harder to fix, so please be patient. |
|
I have tested this item ✅ successfully on f9a1c56 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46358. |
Pull Request for Issue #46352.
Summary of Changes
Currently, when articles are saved from frontend (could be the same for other content types like contacts, weblinks...), version history is not created. The reason is because $context (which we are using to identify content type) will be changed, depend on name of the model. We need to use $typeAlias property from model instead
Testing Instructions
Actual result BEFORE applying this Pull Request
Version History does not work from frontend.
Expected result AFTER applying this Pull Request
Version History works well for frontend.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed