[5.4] Fix condition to check request format in MenusHelper - deprecation warning

[MacJoom]

Pull Request for Issue #45707

Summary of Changes

Check for index.php? instead of index.php before entering parse_url

Testing Instructions

As in described in the issue:

1/ Create a menu item "URL" type - enter just index.php
2/ Set errors report to maximum in global config
3/ A warning shows up in the menu item (backend)

Actual result BEFORE applying this Pull Request

Deprecated: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in /var/www/clients/client2/web46/web/administrator/components/com_menus/src/Helper/MenusHelper.php on line 76

Expected result AFTER applying this Pull Request

No warning

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

I have tested this item 🔴 unsuccessfully on f8d1efd

This does remove the notices but the link does not work
Any url in the format index.php/link will not work (make sure you test from a page that is not the home page

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46341.}

[MacJoom]

I have tested this item 🔴 unsuccessfully on f8d1efdThis does remove the notices but the link does not work Any url in the format index.php/link will not work (make sure you test from a page that is not the home page

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46341.

Yes i see - but this is yet another bug - happens without the patch as well - only happens if you do use things like index.php/team works if you use only /team
We could just replace index.php/xxx with /xxx

[brianteeman]

urls in the format index.php/xxx are created when you enabled SEF urls (the default) and do not enable URL rewriting (the default)

[MacJoom]

Can we just pass this PR that fixes the original issue and open a new issue for the index.php/ bug. Needs to be fixed somewhere else. In the router i guess