[5.4] php temporary folder message

[brianteeman]

Pull Request for Issue #45680

Summary of Changes

Slight language tweak to the two error strings related to the php temporary folder either not being set or not being writeable. Makes the message more specific by explictly writing "upload_tmp_dir"

I see this as a minor tweak/improvement and doesnt change the meaning of the original string so it is fully b/c

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

Does this PR close the referred issue #45680 ?

[brianteeman]

It does as far as I am concerned

[richard67]

I've verified that all usage of language strings "COM_INSTALLER_MSG_WARNINGS_PHPUPLOADNOT..." in our code (com_installer and com_joomlaupdate) refers to the "upload_tmp_dir" variable or to the "UPLOAD_ERR_NO_TMP_DIR" error code caused by that variable not being set.

[richard67]

RTC after 2 review approvals.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46337.}

[muhme]

✅ Final test before merge with JBT, seen the error messages in System > Warning before PR with

• With upload_tmp_dir = "/tmp/upload" and upload_tmp_dir = after:

mkdir /tmp/update && chmod 0 /tmp/update

Installed patch with gh pr checkout 46337 && npm ci

• Checked both error messages, see sample:

[muhme]

Thank you @brianteeman for your contribution. Thank you @tecpromotion and @richard67 for review.