-
-
Couldn't load subscription status.
- Fork 3.7k
[5.4] - Prepend root url to schema images #46306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
travisrisner
wants to merge
8
commits into
joomla:5.4-dev
Choose a base branch
from
travisrisner:recipe-schema
base: 5.4-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@travisrisner Append? Or did you mean prepend? Append means to add to the end, prepend to the beginning. |
This was referenced Oct 17, 2025
richard67
reviewed
Oct 17, 2025
Co-authored-by: Richard Fath <[email protected]>
Good catch, yes prepend! |
Fedik
reviewed
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #46191 & #43955 .
Summary of Changes
Ensures the root domain is appended to image paths for schema images.
Testing Instructions
Actual result BEFORE applying this Pull Request
The images set by schema did not have the root domain prepended and contained extra metadata from joomla about image sizes.
Expected result AFTER applying this Pull Request
The root domain is prepended and the extra information is removed.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed