Add missing dependencies #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency needs to be specified as an author dependency since `SeeAlsoMason.pm` depends upon it, however for some reason `dzil` doesn't list it as a requirement as part of `dzil authordeps` even if it is listed as a normal dependency under the `[Prereqs / RuntimeRequires]` section. Thus, if this module isn't installed, `dzil -Ilib listdeps` will fail and won't list *any* of the required module dependencies. This change works around the issue, listing the module under the author dependencies such that `dzil -Ilib authordeps | cpanm --no-skip-satisfied` installs the required modules for the further functioning of the module when installing from the sources.
`Devel::LeakGuard::Object` had been failing due to changes in `Carp` for quite a while, and thus wouldn't install via `cpanm`. The module has since been updated and the issues corrected and it installs correctly now. The version 0.07 required a very high version of `ExtUtils::MakeMaker` that caused some issues with downstream modules. This requirement has since been relaxed in version 0.08, hence the required minimum version number in this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modules
Moose::AutoboxandDevel::LeakGuard::Objectneed to be installed beforeMasoncan be tested. These commits add these dependencies and their commit messages describe the rationale behind why these changes are necessary.