-
Notifications
You must be signed in to change notification settings - Fork 430
Refactor to use Elektra #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qwepoizt
wants to merge
102
commits into
jonls:814-improve-config
Choose a base branch
from
qwepoizt:improve-config/elektrify
base: 814-improve-config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
102 commits
Select commit
Hold shift + click to select a range
5cfffbb
Add libelektra specification that corresponds to currently supported …
a460cf8
Remove deprecated configuration value "transition" from specification
8cc96b7
Revise naming and hierarchy
5e25918
Change to types that better match possible values
62897f3
Add metadata for required plugins
558c1e2
Add default values
6a9936c
Add "range" metadata
9dd2fcc
Replace regex for time values by check/date
5381b57
Add "require" metadata
b8cfdd1
Remove prefix "redshift/" from key names
b13b051
Revise TODOs
4963eba
Remove infos/plugins (see https://github.com/jonls/redshift/pull/829#…
c00dea1
Add explanation and links about specification files
a4ee0a9
Improve naming and hierarchy of keys
7f32a6b
Add missing example, default and require
0ad584c
Add link to documentation for adjustment method
d1b785d
Improve hierarchy of keys
5bab4e6
Merge duplicate values randr/crtc resp. drm/crtc and randr/screen res…
e50c21d
Improve descriptions of brightness/day and brightness/night
a18c2c6
Fix wrong type and check of gamma, gamma/night and gamma/day
3d9241c
Add note about environment variables
5a34613
Add CLI arguments to spec file
d345ea3
Add opt/arg = required
7bc88e1
Add newline at end of file.
bce2269
Remove obsolete comment, the parts of lcdprocs spec file have been re…
d88215c
Improve comments and configuration setting descriptions
918f66c
Add support for single value gamma values and improve descriptions an…
83f5b3a
Add default option "auto" for adjustment/method and provider/location…
64a188b
Fix type of enum keys
034b2cf
Add missing check/type for float keys
3bd280b
Add files generated by ./bootstrap and ./configure to .gitignore
c4cfbc4
Add folder generated by IntelliJ IDE to .gitinore
d49c5ec
Add line feed to end of file
5115d0c
Merge branch 'extend-gitignore' into improve-config/elektrify
e9527fe
Add libelektra as dependency
770f2e4
Extend specification file to include more keys
f5ff3f6
Fix wrong type of key provider/location
15f6c15
Add range of legal values for keys temp/day and temp/night
0684591
Remove config keys brightness and gamma in favor of their day/night v…
27208ab
Change boolean values from "true", "false" to "1" and "0" as required…
9c4772e
Set default value for lat, lon of location provider manual.
7397bfc
Split up [provider/time/dawn] and [provider/time/dusk] into time ranges.
629d68f
Add note on renaming enum values
1523d42
Add opt/arg = none for keys added in 770f2e4dab0edb1d68dce71b38d3ffa3…
efd0219
Improve description of key [gamma/preserve]
b07298e
Add keys to spec for oneshotmanual, showing list and help for methods…
39d8783
Replace loading of configuration by usage of Elektra
f3a69b6
Remove now unused files config-ini.h and config-ini.c
961c95d
Fix typo
57dad11
Add files generated by Elektra to .gitignore
09dc284
Add kdb gen and mount to autotools configuration and contributing doc…
5f85949
Fix parallel execution of make
20f9890
Update README.md with infos about changing configuration and remove o…
06c4744
Add note that mounting specification requires root privileges.
1811230
Reformat comment about specification files
6e44e5a
Change file suffix of specification file to .ni.
1c946bb
Add organisation part "jonls" to redshift's application key name.
6cac794
Improve description and fix wrong mapping of "fastfade" option.
5c1b3c2
Ensure string format of configured location is compatible with specif…
df9937f
Remove obsolete compass direction abbreviations.
4593953
Add human-readable error message for options gamma/day and gamma/night.
65fcae3
Remove obsolete comments from specification file.
0faff13
Fix typo.
2d099f1
Add info about negative values for "lat" and "lon" options.
b677acf
Refactor mapping of programm mode from if-else to switch.
ef12443
Improve error messages for unsupported location provider/adjustment m…
b0d66c6
Make error messages more user-friendly
f8d59d2
Improve error messages
9c0bf1b
Improve error message about no working location provider
39468d0
Add line breaks to error messages
268a813
Improve usability of automatic adjustment method selection:
ea42cf2
Improve usability of method and location provider listing.
5ccebbb
Improve usability of auto mode for method and location provider.
4c7e663
Improve usability of auto mode for method and location provider.
8785b45
Use stderr only for errors, not for infos.
35eabb1
Improve info messages for auto mode for method and location provider.
42b5768
Improve info message for location available.
c6b8e47
Revert CONTRIBUTING.md which was commited too early in 4c7e6636b8ac6e…
52f3417
Improve CONTRIBUTING.md:
4868f61
Move check for version flag to the top of option parsing so redshift …
49e197e
Implement printing help messagewhen short CLI option "-h" is used.
80314eb
Change key hierarchy and CLI option name of "fastfade"
2555f15
Remove dependency to file redshift.conf.sample from Makefile.am and a…
f90b740
Add copy of redshift.ni in dump format for windows builds
b22f577
Download and install Elektra during appveyor build
73fd5ee
Replace wget by curl in appveyor.yml script
121bc39
Replace cur by Start-FileDownload in appveyor.yml script
6b29a59
Fix typo in appveyor.yml
3e6b135
Replace unzip by 7z in appveyor.yml script
268ef91
Fix wrong path in appveyor.yml
500feb6
Fix wrong path in appveyor.yml
d97c3f5
Replace Redshift's program_mode_t enum by enum generated by Elektra
632fb69
Remove Redshift's validation of temperature and brightness values bec…
90246d6
Make files generated by elektra compatible with windows builds
ad74259
Remove reference to already deleted file src/config.ini.c from POTFIL…
56f6294
Fix AC_DEFINE
6f652de
Fix makefile for windows builds, add elektra resources to zip artefact
164db0c
Rewrite appveyor.yml to support Redshift with Elektra
1136781
Replace ELEKTRA_DOWNLOAD_URL with "master"
67d925e
Merge remote-tracking branch 'qwepoizt/adapt-for-windows' into improv…
750344b
Add macro branching in options.h
dcd3ab8
Add files generated by Elektra to git, document how to regenerate them.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would surprise me very much if autotools do not already have a solution for that.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, thank you!
I haven't found a more elegant way to accomplish this and I found this solution to have a big benefit:
WINDOWS_BUILDwill be defined if and only if the rest of the build will also be made Windows-compatible.E.g. a solution like https://stackoverflow.com/a/38899152 would have most of the build depend on
AC_CHECK_TOOL([WINDRES], [windres], [])whileWINDOWS_BUILDwould only be defined if${host_os}matchesmingw*.