Add a dedicated lambda bin#218
Merged
Merged
Conversation
rustworthy
commented
Jan 19, 2025
rustworthy
commented
Jan 19, 2025
rustworthy
changed the title
--release not speciallambda bin
rustworthy
commented
Jan 19, 2025
rustworthy
changed the title
lambda binlambda bin
24 tasks
jonhoo
approved these changes
Feb 8, 2025
Owner
jonhoo
left a comment
jonhoo
left a comment
There was a problem hiding this comment.
I love this change! Just a few nits and then we can land it 🎉
rustworthy
force-pushed
the
release-not-special
branch
from
15ff917 to
3d49629
Compare
jonhoo
approved these changes
Feb 9, 2025
Owner
|
I'm not quite sure why the Terraform plan job complains about |
Contributor
Author
The runner may be picking up my repo's config, since I got workflows enabled for my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first iteration on #202
I have not found a way to provide flags/args to the lambda runtime, they just taking a
bootstrapbinary from us and that's it.So what I am suggesting instead, is to locate the core logic in the lib and have numerous binaries - two for now. The default bin will be binding to a socket, while the
--bin lambdawill produce a lambda-layered app ready for AWS Lambda runtime. This has a benefit of only including the code we need to the default binary and not adding lambda runtime specific stuff.We will still need logic for parsing command line args for the default binary (to accomplish the testing aspect of #202), but I think we could address it in a dedicated PR.
P.S.: I am suggesting to put auxiliary functions to the
utilsmodule