Skip to content

Update (fraction api) recipeView.js #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update (fraction api) recipeView.js #460

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions 18-forkify/final/src/js/views/recipeView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import View from './View.js';

// import icons from '../img/icons.svg'; // Parcel 1
import icons from 'url:../../img/icons.svg'; // Parcel 2
import { Fraction } from 'fractional';

// old (not working)
// import { Fraction } from 'fractional';

// new
import Fraction from 'fraction.js';

class RecipeView extends View {
_parentElement = document.querySelector('.recipe');
Expand Down Expand Up @@ -127,8 +132,10 @@ class RecipeView extends View {
<svg class="recipe__icon">
<use href="${icons}#icon-check"></use>
</svg>
<div class="recipe__quantity">${
ing.quantity ? new Fraction(ing.quantity).toString() : ''
<div class="recipe__quantity">

${
ing.quantity ? new Fraction(ing.quantity).toFraction(true) : ''
}</div>
<div class="recipe__description">
<span class="recipe__unit">${ing.unit}</span>
Expand Down