Added support for PSS alogrithm varations #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Owner
|
Nice one! I've just read your conversation on the issue and indeed I forgot this speficiation when I implemented the PSS. LGTM but can you modify the tests to take this change? |
Contributor
Author
No problem. Will update the tests asap. |
jonasroussel
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ammended the sign and verify functions to support PSS algorithm variations. Resolving a bug causing invalid signature response due to incorrect byte size used during sign process. Support now added for PS256/384/512 and corresponding byte size.
#58
Credit to user613 for identifing the issue.