Skip to content

React upgrade 18.2.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

React upgrade 18.2.0 #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f581ab
Update to 10.0
bollain Apr 1, 2023
baf8352
Fix API for 10
bollain May 9, 2023
4cadb26
Remove styles that were making the viewer not take up the entire view…
mparizeau-pdftron Jul 28, 2023
19055c4
react 18.2.0 upgrade.
dheu-dvelop Nov 29, 2023
2f06127
readded readme changes from master branch
dheu-dvelop Nov 29, 2023
647e5d6
Merge branch 'master' into react-upgrade-18.2.0
thebiff999 Nov 29, 2023
faabdf4
fixed syntax-error in package.json
dheu-dvelop Nov 29, 2023
7ecc376
undo readme changes as they stem from the origin of the fork.
dheu-dvelop Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# DocumentViewer bug showcase

This repository is a fork of [webviewer-custom-ui](https://github.com/PDFTron/webviewer-custom-ui) to reproduce bugs.

# Reported Bugs:
- [Document not rendering when DocumentViewer is loaded in an absolut right positioned parent](https://github.com/jonasherbert/documentviewer-core/tree/position-absolute-right)

- [Initial loadtime of documents in mobile webkit browsers with iOS < 17.0.0 takes distintly longer](https://support.apryse.com/support/tickets/58437)
9 changes: 4 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
"version": "1.0.0",
"private": true,
"dependencies": {
"@pdftron/webviewer": "^8.0.0",
"react": "^16.13.1",
"react-dom": "^16.13.1",
"react-scripts": "3.4.3"
"@pdftron/webviewer": "^10.5.0",
"react": "^18.2.0",
"react-dom": "^18.2.0"
},
"devDependencies": {
"btoa": "^1.2.1",
Expand All @@ -29,4 +28,4 @@
"not ie <= 11",
"not op_mini all"
]
}
}
Binary file renamed public/files/pdftron_about.pdf → public/files/demo.pdf
View file
Open in desktop
Binary file not shown.
10 changes: 5 additions & 5 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ReactComponent as ZoomIn } from './assets/icons/ic_zoom_in_black_24px.s
import { ReactComponent as ZoomOut } from './assets/icons/ic_zoom_out_black_24px.svg';
import { ReactComponent as AnnotationRectangle } from './assets/icons/ic_annotation_square_black_24px.svg';
import { ReactComponent as AnnotationRedact } from './assets/icons/ic_annotation_add_redact_black_24px.svg';
import { ReactComponent as AnnotationApplyRedact} from './assets/icons/ic_annotation_apply_redact_black_24px.svg';
import { ReactComponent as AnnotationApplyRedact } from './assets/icons/ic_annotation_apply_redact_black_24px.svg';
import { ReactComponent as Search } from './assets/icons/ic_search_black_24px.svg';
import { ReactComponent as Select } from './assets/icons/ic_select_black_24px.svg';
import { ReactComponent as EditContent } from './assets/icons/ic_edit_page_24px.svg';
Expand Down Expand Up @@ -34,8 +34,8 @@ const App = () => {
const documentViewer = new Core.DocumentViewer();
documentViewer.setScrollViewElement(scrollView.current);
documentViewer.setViewerElement(viewer.current);
documentViewer.setOptions({ enableAnnotations: true });
documentViewer.loadDocument('/files/pdftron_about.pdf');
documentViewer.enableAnnotations();
documentViewer.loadDocument('/files/demo.pdf');

setDocumentViewer(documentViewer);

Expand All @@ -47,11 +47,11 @@ const App = () => {
}, []);

const zoomOut = () => {
documentViewer.zoomTo(documentViewer.getZoom() - 0.25);
documentViewer.zoomTo(documentViewer.getZoomLevel() - 0.25);
};

const zoomIn = () => {
documentViewer.zoomTo(documentViewer.getZoom() + 0.25);
documentViewer.zoomTo(documentViewer.getZoomLevel() + 0.25);
};

const startEditingContent = () => {
Expand Down